Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always save nonpersisted ACLs #6930

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Always save nonpersisted ACLs #6930

wants to merge 5 commits into from

Conversation

dlpierce
Copy link
Contributor

Summary

Calling save on a new (unpersisted) ACL object should persist it even when there are no changes otherwise.

@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Oct 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Test Results

    17 files  ± 0      17 suites  ±0   2h 18m 20s ⏱️ + 1m 6s
 6 719 tests + 5   6 419 ✅ +2  297 💤 ±0  3 ❌ +3 
13 208 runs  +10  12 808 ✅ +6  396 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit 063651b. ± Comparison against base commit e11d5d0.

This pull request removes 273 and adds 278 tests. Note that renamed tests count towards both. 
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f0f0e51cbc8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f913648e260>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f0f0e8d5dc8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f9136a3f650>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: c5581b9d-5f87-4ca0-bb40-c402252e4616
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 408c4791-cad3-4671-8811-259111d4c82d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: bec84e8f-1074-4f28-91dd-e5ae0675e372
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: ebf9bd2a-60cd-4b2b-b572-1466a1fef4f8
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: babadee6-44e9-43a8-b98c-a0edee5811dc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: bd2bae10-c843-457d-9d14-d895987c0384
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007efe8b041f60>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fe6d0449760>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007efe8a919260>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fe6cf1320a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 8ccfd678-e30d-43ce-81cb-ce5880a0c42d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 752988c6-8a98-49b9-96c7-ea52f70bee9d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 46133fde-a88d-403a-8c21-823920f5e501
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 6c591265-49b7-4037-8df0-119b9db12209
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: d737d023-881b-454a-83f8-caa23288dfde
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: a3ec8688-0c46-4562-b57c-702aa90341ee
…

♻️ This comment has been updated with latest results.

@dlpierce
Convert Ldp::Gone to ObjectNotFoundError
868af43 
Ldp::Gone is the error raised by the fedora adapter when the resource is a tombstone after being deleted.
@dlpierce
Test using a real adapter
b59887d
@dlpierce
Fix incorrect use of block with raise_error
2265337 
This was causing any raised error to be considered a pass, which is clearly not the intent.

Fixing this revealed a problem caused by using Valkyrie::Resource directly. Required attributes
were missing because they are only defined when the Valkyrie::Resource is inherited.
@dlpierce
Fix specs that didn't expect an ACL save
063651b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dlpierce