-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always save nonpersisted ACLs #6930
Open
dlpierce
wants to merge
5
commits into
main
Choose a base branch
from
always_save_new_acl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpierce
force-pushed
the
always_save_new_acl
branch
from
October 24, 2024 19:59
1c4ef68
to
c42c31c
Compare
Test Results 17 files ± 0 17 suites ±0 2h 18m 20s ⏱️ + 1m 6s For more details on these failures, see this check. Results for commit 063651b. ± Comparison against base commit e11d5d0. This pull request removes 273 and adds 278 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Ldp::Gone is the error raised by the fedora adapter when the resource is a tombstone after being deleted.
This was causing any raised error to be considered a pass, which is clearly not the intent. Fixing this revealed a problem caused by using Valkyrie::Resource directly. Required attributes were missing because they are only defined when the Valkyrie::Resource is inherited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Calling save on a new (unpersisted) ACL object should persist it even when there are no changes otherwise.