Ruby 3.1 and Rails 6.1 support #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddierubeiz
force-pushed
the
rails_3_1
branch
2 times, most recently
from
85bc5f1
to
8d6303b
Compare
jrochkind
reviewed
Jul 14, 2022
jrochkind
reviewed
Jul 14, 2022
jrochkind
reviewed
Jul 14, 2022
jrochkind
reviewed
Jul 14, 2022
|
@eddierubeiz The PR title says "Rails 3.1 support". -- it's actually Ruby 3.1 support of course. Fix? If there are versions of Rails added in this PR, mention them too. Then this looks mergeble to me, hooray! |
jrochkind
approved these changes
Jul 18, 2022
|
Sweet, thanks @eddierubeiz ! All the hard work you did in previous PR's made this final PR simple. Should we do a questioning_authority release? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'mail', '>= 2.8.0.rc1'psych < 4'net-smtp', require: falseThis should address both #345 and #331.