Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement #100 and scrape CSS images too #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

implement #100 and scrape CSS images too #104

wants to merge 2 commits into from

Conversation

paralax
Copy link

@paralax paralax commented Jul 28, 2017

cut and paste code from @kennedyshead

@coveralls
Copy link

coveralls commented Jul 28, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-1.2%) to 47.423% when pulling 7e0ed05 on paralax:master into 68c39fd on sananth12:master.

sananth12
sananth12 reviewed Jul 31, 2017
View reviewed changes
image_scraper/utils.py

for image in image_list:
if image.startswith('//'):
image = 'https:' + image
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would http be a better idea?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should use the same as the URL put in to process ;) if not '//' is possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennedyshead kennedyshead kennedyshead left review comments

@sananth12 sananth12 sananth12 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paralax @coveralls @kennedyshead @sananth12