-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix enabling of Use Serial Mesh #762
Conversation
…e Use Serial Mesh
This is related to #761. |
Thanks @mperego ! I'll test this out on camobap later this afternoon. |
@ikalash Thanks!
were if-guarded by Albany_IOPX and were never enabled. This PR enables them and they are now failing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a print of whether ALBANY_PARALLEL_EXODUS is true/false in the CMakeLists.txt file? Would be useful to see this in the configure step, for debugging, etc.
Thanks for the heads up - I'll fix this. |
CMakeLists.txt
Outdated
return 0; | ||
} | ||
" | ||
PARALLEL_EXODUS_SUPPORTED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason not to just use ALBANY_PARALLEL_EXODUS
as output variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really. I thought that
Performing Test PARALLEL_EXODUS_SUPPORTED - Success
was more expressive but at the same time wanted to keep Albany way of naming variables. I can change that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's fine. I was just curious if there was some weird techincality in the CheckFunctionExists macro maybe. This is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have one comment, but not very important.
Yes, what message would you like to print? I don't see it done in a consistent way. Something like |
Yes exactly - to be consistent with the other messages printed when you configure Albany. |
This looks good. I just verified that everything is OK on camobap with your change. I'll go ahead and merge. |
@ikalash thanks for checking camobap. I usually prefer to rebase and merge to avoid useless merge commits. B.t.w. the failing CahnHill tests don't appear on Camobap because ALBANY_PARALLEL_EXODUS is false there. |
@mperego , yes, thank you for the reminder. I'll fix it in master. |
Check whether parallel ExodusII is available and use it to conditionally enable Use Serial Mesh. Thanks @bartgol for helping.