Various Fixes for Actions Taken on VMs #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jacdavi this sounds great! I'm glad you were able to figure out the miniccc snapshot issue. I've been trying to find time to look into that. I'll do my best (I know I say this a lot 😂) to get this and your other PRs reviewed and merged within the next week or so. I know you're already using them but they would for sure benefit the larger user base as well. Thanks again! |
activeshadow
force-pushed
the
vm-action-fixes-gh
branch
from
b6f1bd8
to
f63c46d
Compare
|
@jacdavi I've rebased this onto the latest main branch. I'll try to do some testing ASAP and get it merged in before main gets too far ahead again... 😂 |
change to maintain uuid after restore
When Readdir returns an error, it may still have a list of files read up until that point. Previously we returned early if there was an error, rather than returning those files. This was prevalent when looking in certain directories such as "/etc" of an Ubuntu desktop. Output should not match results of "ls -la" in mounted directory
activeshadow
force-pushed
the
vm-action-fixes-gh
branch
from
f63c46d
to
4cf9373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few bugs with the actions you can take on a booted VM
os.Readdirreturned an error, but it returns the files read up until the error as well. This change returns those files. This fixes an issue in some directories (such as/etcon an Ubuntu host) being empty. Results should now be equivalent of mounting and runninglson command linepsfor determining minimega's pathminimegawhere I added a newargscommand