Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to newest Meteor and MongoDB, if possible. #36

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

xet7
Copy link

@xet7 xet7 commented May 2, 2022

No description provided.

package.js Outdated
@@ -30,7 +30,7 @@ Package.onUse(function(api) {
api.versionsFrom('1.5.1');

api.use('random', ['client', 'server']);
api.use('accounts-base', ['client', 'server'], {weak: true});
api.use('accounts-base@2.2.2', ['client', 'server'], {weak: true});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems strange to specify this version here, when the version isn't specified on any other package here? Shouldn't this pull the latest version without this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I did not specify version, I did get version conflict about when trying to add fork to WeKan. Maybe it could work without specifying version?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I notice your version in the wekan repo branch has already moved to a 2.2.3-rc. I think we probably don't want to have to update this package for each and every revision of accounts-base to avoid a version conflict.

(As a note, I am not sure how quickly Kenton will get to updating this package, so working with a forked version in the interim is probably a good idea.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I did already fork this meteor-accounts-sandstorm directly to wekan/packages . There is still a lot to fix before wekan upgrade-meteor branch has everything working, it's on bleeding edge.

wekan/wekan@f260b7b

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also related:

wekan/wekan@255eac9

@ocdtrekkie
Copy link

Are you publishing this under your namespace now? That may make sense for the time being. Eventually it may be nice to establish a Sandstorm org for this, but if this makes it easy for you to proceed, I think Kenton is pretty busy right now.

@xet7
Copy link
Author

xet7 commented Apr 5, 2023

@ocdtrekkie

Yes, to https://www.npmjs.com/package/@wekanteam/accounts-sandstorm

I did not check yet how https://atmospherejs.com works, do I have working account there yet. There also has been sometime discussion about Meteor packages moving from https://atmospherejs.com to https://npmjs.com . There is also https://github.com/Meteor-Community-Packages but I don't have direct access to add repos and packages there. I'm already familiar with publishing packages to https://npmjs.com , like these at https://www.npmjs.com/search?q=%40wekanteam , someone even donated some cloud services because I did maintain mermaid related package.

I will also move some other packages to https://npmjs.com , so that they would be easier to use for me.

Sure if someone else also has time to maintain something, it's easy to clone repos, add new packages etc.

@xet7
Copy link
Author

xet7 commented Apr 5, 2023

@ocdtrekkie

I'm currently trying could I get newest WeKan with newest Meteor working with old MongoDB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants