Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't commit enter_grain executable to the repo. #253

Open
zenhack opened this issue Jan 31, 2020 · 0 comments
Open

Don't commit enter_grain executable to the repo. #253

zenhack opened this issue Jan 31, 2020 · 0 comments

Comments

@zenhack
Copy link
Collaborator

zenhack commented Jan 31, 2020

It's 200K; we don't want to be committing new versions of that each time. Maybe we'll just end up replacing this with a use of nsenter, so the point will be moot.
@zenhack zenhack mentioned this issue Jan 31, 2020
Open
@ocdtrekkie ocdtrekkie mentioned this issue Jan 31, 2020
Merged
zenhack added a commit to zenhack/vagrant-spk that referenced this issue Jan 31, 2020
@zenhack
Fix sandstorm-io#251 and some bitrot in enter_grain
8ce6bd4 
This is one commit instead of two because we didn't want to bloat the
repository with two updates to the executable. We should really just
remove the binary from the repo and build it; see sandstorm-io#253

The bitrot:

With #![feature(alloc_system)] I get an error from the rust toolchain
that the feature has been removed. We don't appear to actually be using
this anyway, so let's just remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zenhack