Fix some bitrot in enter_grain #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe hold off on this one until we decide whether to just switch over to using nsenter. |
|
@zenhack Agreed on that. |
|
I'm excited to see the bitrot being fixed, and also excited to see the
possibility that we'll delete this code. :)
For what it's worth, some of the flags I was using were due to my desire to
keep the output binary file as small as possible. Maybe this was one of
them.
|
|
Hm, the binary on master is >600K vs this one at 200K, so if that's the case, the compiler has gotten better by a margin that swallows those savings pretty thoroughly. We still shouldn't commit it to the repo though... |
|
Since #253 is concerned about excess commits of binary files, if you fix the enter-grain binary, can we get both this fix and that fix in a single commit, so we are only adding one copy of the binary? |
|
Sure, I'll --amend it onto this one. We can maybe do the PyPI packaging soonish so we don't have to worry about this again. |
zenhack
force-pushed
the
enter-grain-toolchain-bitrot
branch
from
6abf69b
to
11f9474
Compare
|
@ocdtrekkie, updated. should work now. |
This is one commit instead of two because we didn't want to bloat the repository with two updates to the executable. We should really just remove the binary from the repo and build it; see sandstorm-io#253 The bitrot: With #![feature(alloc_system)] I get an error from the rust toolchain that the feature has been removed. We don't appear to actually be using this anyway, so let's just remove it.
zenhack
force-pushed
the
enter-grain-toolchain-bitrot
branch
from
11f9474
to
8ce6bd4
Compare
|
I tested this locally and I'm happy with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with #![feature(alloc_system)] I get an error from the rust toolchain
that the feature has been removed. We don't appear to actually be using
this anyway, so let's just remove it.