Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include the shell in the spk for go stacks. #206

Merged
merged 1 commit into from
Apr 27, 2017

Conversation

zenhack
Copy link
Collaborator

@zenhack zenhack commented Apr 26, 2017

No description provided.

@zarvox zarvox merged commit 25475b7 into sandstorm-io:master Apr 27, 2017
@zarvox
Copy link
Collaborator

zarvox commented Apr 29, 2017

In hindsight, you can accomplish this (less conveniently, perhaps) by editing the sandstorm-pkgdef.capnp after calling spk init to directly launch /opt/app/app rather than /opt/app/.sandstorm/launcher.sh.

@zenhack Do you mind if I revert this and merge #184 so things can work out-of-the-box for Windows users? As noted above, you can still achieve the "avoid including bash in the package" outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants