Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #29 - Report error when jump to definition doesn't find var #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bbuccianti
Copy link
Contributor

I know it's not the most elegant solution, but it's working.

Let me know if some changes are needed.

Thanks!

@bbuccianti
Copy link
Contributor Author

With the last force-push I've added the lexical-binding: t as a file variable in order to use a closure in monroe-eval-jump. This work as a medium to have the var and ns we are looking for inside the callback.

Please let me know if changes are needed.

Thanks!

@bbuccianti
Copy link
Contributor Author

I've added the closure for have ns on the calback, but never used it! My mistake. Now I think it's okay.

@sanel
Copy link
Owner

sanel commented Oct 13, 2020

Thank you for this! Can you just please show me example of what it tries to address?

@bbuccianti
Copy link
Contributor Author

Sure!

On this issue #29 , you've added a sample implementation for a way to being able to jump to function definitions. I've just taked that, and make it work with current state of the project (monroe).

Personally, I've never used that feature, but a few tests showed that it's working properly. You just need to make a function and from a invocation you can try monroe-jump and you're there. In the case the function doesn't exist, the nrepl server return a exception and that's when we know that we can't jump to that function (I think). So it shows you with a message which function was looking for and in which namespace.

Let me know if this helps!

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants