chore(test): fix unit test caching issues #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Oct 30, 2023 4:41 PM (UTC)
|
binoy14
changed the title
- chore(test): add delete cache job after build finishes - chore(test): use restore cache action in test build to make sure cache is immutable in tests
binoy14
force-pushed
the
chore/fix-test-cache
branch
from
0e20e87
to
4976cf5
Compare
skogsmaskin
pushed a commit
that referenced
this pull request
Nov 2, 2023
- chore(test): add delete cache job after build finishes - chore(test): use restore cache action in test build to make sure cache is immutable in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issues with immature caching behaviors added in #5069 for unit tests in PRs where the first commit build got cached and was not getting cleaned on next commit or re-run of the action. The change now uses the run id and removes the
restore_keysto make sure the correct artifact is used across steps. As an extra precaution, there is also a delete job added that will delete cache after the workflow run is completed.What to review
Changes makes sense
Notes for release