feat(codegen): add groq finder methods. #5980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 12, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sgulseth
force-pushed
the
03-12-feat_codegen_add_codegen_skeleton_package
branch
from
95449ab
to
aaa72e0
Compare
Full Report@sanity/codegen
@sanity/migrate
sanity
@sanity/diff
@sanity/block-tools
@sanity/types
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
sanity/structure
@sanity/util/concurrency-limiter
@sanity/util/legacyDateFormat
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/client
@sanity/util/createSafeJsonParser
sanity/_internalBrowser
@sanity/util/content
|
|
Component Testing Report Updated Mar 19, 2024 3:10 PM (UTC)
|
sgulseth
force-pushed
the
03-12-feat_codegen_add_codegen_skeleton_package
branch
from
aaa72e0
to
2715130
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_groq_finder_methods
branch
from
eebcae8
to
e133519
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_codegen_skeleton_package
branch
from
2715130
to
dff8b1b
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_groq_finder_methods
branch
from
e133519
to
f222a5c
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_codegen_skeleton_package
branch
from
dff8b1b
to
030c196
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_groq_finder_methods
branch
from
f222a5c
to
16f66a4
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_codegen_skeleton_package
branch
from
030c196
to
09ffc07
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_groq_finder_methods
branch
from
16f66a4
to
3d97029
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_groq_finder_methods
branch
from
3d97029
to
2f8abf0
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_codegen_skeleton_package
branch
from
09ffc07
to
3ebeed1
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_groq_finder_methods
branch
from
2f8abf0
to
c245d16
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_codegen_skeleton_package
branch
from
13e2dc1
to
ebb4619
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_groq_finder_methods
branch
from
150e40e
to
c15fbbd
Compare
ricokahler
approved these changes
Mar 17, 2024
| ) | ||
| } | ||
|
|
||
| function resolveClass({ |
There was a problem hiding this comment.
Did I remember you saying you removed support for classes? Is this the right code?
There was a problem hiding this comment.
Ah, great catch! forgot this one 🙃
sgulseth
force-pushed
the
03-12-feat_codegen_add_codegen_skeleton_package
branch
from
ebb4619
to
6a7b5b0
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_groq_finder_methods
branch
from
c15fbbd
to
0d3d984
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_codegen_skeleton_package
branch
from
6a7b5b0
to
f221971
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_groq_finder_methods
branch
from
0d3d984
to
2a71264
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_codegen_skeleton_package
branch
from
f221971
to
f6fc884
Compare
sgulseth
force-pushed
the
03-12-feat_codegen_add_groq_finder_methods
branch
from
2a71264
to
0d83227
Compare
Base automatically changed from
03-12-feat_codegen_add_codegen_skeleton_package
to
next
March 19, 2024 15:00
Adds methods that parses a js/ts source file and returns all groq queries. co-authored-by: Tonina Zhelyazkova <[email protected]>
sgulseth
force-pushed
the
03-12-feat_codegen_add_groq_finder_methods
branch
from
0d83227
to
fbab4df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds babel runtime capabilities to scan a given source file for groq queries.
It checks for GROQ tagged template literal that's assigned to a variable, and tries to extract the value. It tries to follow variable references through resolving file local variables, but also imports/exports.
What to review
Testing
We've added the tests for the most expected code paths, but more suggestions are also welcome.
We don't test the custom resolver now, as it's deemed best effort...
Notes for release
N/A - No notes needed.