Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): use studioHost from CLI config for intent link #7570

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(cli): use studioHost from CLI config for intent link #7570

merged 1 commit into from
Oct 3, 2024

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Oct 2, 2024 •
edited
Loading

Description

Updates the validate command to use studioHost configured in the CLI config instead of relying on the projects endpoint studioHost for this information.

What to review

Changes makes sense

Testing

Tests Updates

Notes for release

N/A (does not seem it is important to mention in release notes)

@vercel Vercel
Copy link

vercel bot commented Oct 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 1:13am
performance-studio ✅ Ready (Inspect) Visit Preview Oct 2, 2024 1:13am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 1:13am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 1:13am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 1:13am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 1:13am

@binoy14 Graphite App
Copy link
Contributor Author

binoy14 commented Oct 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @binoy14 and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

No changes to documentation

@binoy14 binoy14 marked this pull request as ready for review October 2, 2024 01:12
@binoy14 binoy14 requested a review from a team as a code owner October 2, 2024 01:12
@binoy14 binoy14 requested review from ricokahler and removed request for a team October 2, 2024 01:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Component Testing Report Updated Oct 2, 2024 1:17 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 34s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 15s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 25s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 19s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 34s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

⚡️ Editor Performance Report

Updated Wed, 02 Oct 2024 01:22:47 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 18.5 efps (54ms) 18.2 efps (55ms) +1ms (+1.9%) ✅
article (body) 62.9 efps (16ms) 62.9 efps (16ms) +0ms (-/-%) ✅
article (string inside object) 20.4 efps (49ms) 20.0 efps (50ms) +1ms (+2.0%) ✅
article (string inside array) 15.4 efps (65ms) 15.4 efps (65ms) +0ms (-/-%) ✅
recipe (name) 31.3 efps (32ms) 32.3 efps (31ms) -1ms (-3.1%) ✅
recipe (description) 35.1 efps (29ms) 36.4 efps (28ms) -1ms (-3.5%) ✅
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%) ✅
synthetic (title) 15.2 efps (66ms) 15.4 efps (65ms) -1ms (-1.5%) ✅
synthetic (string inside object) 15.6 efps (64ms) 15.6 efps (64ms) +0ms (-/-%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 54ms 57ms 66ms 139ms 906ms 14.8s
article (body) 16ms 18ms 22ms 128ms 182ms 5.2s
article (string inside object) 49ms 51ms 59ms 109ms 675ms 8.2s
article (string inside array) 65ms 69ms 80ms 154ms 1593ms 9.6s
recipe (name) 32ms 36ms 41ms 101ms 54ms 10.4s
recipe (description) 29ms 30ms 34ms 54ms 30ms 6.2s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.2s
synthetic (title) 66ms 69ms 75ms 277ms 1924ms 16.4s
synthetic (string inside object) 64ms 67ms 71ms 169ms 1760ms 10.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 55ms 58ms 73ms 144ms 1021ms 14.7s
article (body) 16ms 19ms 21ms 117ms 151ms 5.2s
article (string inside object) 50ms 52ms 59ms 167ms 673ms 8.6s
article (string inside array) 65ms 68ms 75ms 129ms 1517ms 9.4s
recipe (name) 31ms 34ms 39ms 63ms 52ms 10.6s
recipe (description) 28ms 29ms 31ms 51ms 19ms 6.0s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.2s
synthetic (title) 65ms 69ms 73ms 205ms 1981ms 17.4s
synthetic (string inside object) 64ms 67ms 75ms 278ms 1767ms 9.9s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

ricokahler
ricokahler approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@ricokahler ricokahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a straightforward way to do it if i'd say so!

@binoy14 binoy14 added this pull request to the merge queue Oct 3, 2024
Merged via the queue into next with commit e098800 Oct 3, 2024
52 checks passed
@binoy14 binoy14 deleted the sdx-1490 branch October 3, 2024 16:13
ricokahler pushed a commit that referenced this pull request Oct 4, 2024
@binoy14 @ricokahler
fix(cli): use studioHost from CLI config for intent link (#7570)
818e151 
### Description

<!--
What changes are introduced?
Why are these changes introduced?
What issue(s) does this solve? (with link, if possible)
-->

Updates the validate command to use studioHost configured in the CLI
config instead of relying on the projects endpoint studioHost for this
information.

### What to review

<!--
What steps should the reviewer take in order to review?
What parts/flows of the application/packages/tooling is affected?
-->

Changes makes sense

### Testing

<!--
Did you add sufficient testing for this change?
If not, please explain how you tested this change and why it was not
possible/practical for writing an automated test
-->

Tests Updates

### Notes for release

<!--
Engineers do not need to worry about the final copy,
but they must provide the docs team with enough context on:

* What changed
* How does one use it (code snippets, etc)
* Are there limitations we should be aware of

If this is PR is a partial implementation of a feature and is not
enabled by default or if
this PR does not contain changes that needs mention in the release notes
(tooling chores etc),
please call this out explicitly by writing "Part of feature X" or "Not
required" in this section.
-->

N/A (does not seem it is important to mention in release notes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricokahler ricokahler ricokahler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binoy14 @ricokahler