-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prepare nextjs starter template for live mode #7633
base: next
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Oct 28, 2024 12:44 AM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Mon, 28 Oct 2024 00:47:02 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the next-sanity docs, it seems like the live content API might require vX to be used - are you okay leaving that up to the env file? Also, are we leaving the SanityLive
component up to the user to implement "if they want it"?
@@ -165,6 +165,12 @@ export const client = createClient({ | |||
}) | |||
` | |||
|
|||
const live = `import { defineLive } from "next-sanity"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add a description to the top for what this file is for?
const live = `import { defineLive } from "next-sanity"; | |
// Importing and querying through `sanityFetch` from this file will make data automatically stay up to date with any changes. | |
// Before using it, import and render `<SanityLive />` in your layout - see | |
// https://github.com/sanity-io/next-sanity#live-content-api for more information. | |
const live = `import { defineLive } from "next-sanity"; |
Description
Adds configuration file for live fetches when initializing a new Studio inside a Next.js application. Not used by the Studio, but designed for use in the Next.js application.
Do not release until the next version of next-sanity is available.
Notes for release
sanityFetch
andSanityLive
preconfigured for Studios initialized inside a Next.js application