fix: various layout + copy updates #7656

robinpyon · 2024-10-22T16:45:26Z

Changes

Various copy and layout tweaks, exemplified below with screenshots
We display an 'Untitled' fallback title (served from i18n resources) when unlinking a document with no title
Linked banner popover is now dismissible with ESC

Using default tone for primary CTA

New Create SVG, updated copy + layout

Updated linking in progress dialog layout + copy, with toggleable 'troubleshooting' section (displaying open state)

Post-sync screen is basically the same, sans a minor border tweak

Post-sync banner popover – updated layout and copy. Re-using the same image for now.

Post-sync unlink popover – untitled fallback, minor quote tweaks

vercel · 2024-10-22T16:45:30Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 6:53pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 6:53pm
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 6:53pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 6:53pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 6:53pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Oct 22, 2024 6:53pm

github-actions · 2024-10-22T16:46:26Z

No changes to documentation

github-actions · 2024-10-22T16:51:40Z

Component Testing Report Updated Oct 22, 2024 6:50 PM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	46s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	9s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	32s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	39s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	18s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	10s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	2m 32s	1	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	47s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 45s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 18s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	9s	3	9
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	27s	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	18s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	37s	12	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-10-22T16:56:41Z

⚡️ Editor Performance Report

Updated Tue, 22 Oct 2024 18:52:37 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	17.2 efps (58ms)	16.8 efps (60ms)	+2ms (+2.6%)	✅
article (body)	56.7 efps (18ms)	75.5 efps (13ms)	-4ms (-24.9%)	✅
article (string inside object)	17.7 efps (57ms)	17.5 efps (57ms)	+1ms (+0.9%)	✅
article (string inside array)	14.8 efps (68ms)	14.5 efps (69ms)	+2ms (+2.2%)	✅
recipe (name)	30.3 efps (33ms)	29.4 efps (34ms)	+1ms (+3.0%)	✅
recipe (description)	34.5 efps (29ms)	32.3 efps (31ms)	+2ms (+6.9%)	✅
recipe (instructions)	99.9+ efps (6ms)	99.9+ efps (6ms)	+0ms (-/-%)	✅
synthetic (title)	14.1 efps (71ms)	13.9 efps (72ms)	+1ms (+1.4%)	✅
synthetic (string inside object)	15.2 efps (66ms)	15.2 efps (66ms)	+0ms (-/-%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	58ms	62ms	78ms	174ms	359ms	13.1s
article (body)	18ms	19ms	48ms	215ms	350ms	6.2s
article (string inside object)	57ms	60ms	67ms	224ms	490ms	9.2s
article (string inside array)	68ms	69ms	79ms	213ms	931ms	9.6s
recipe (name)	33ms	36ms	42ms	66ms	0ms	9.5s
recipe (description)	29ms	31ms	36ms	74ms	0ms	6.1s
recipe (instructions)	6ms	8ms	9ms	10ms	0ms	3.1s
synthetic (title)	71ms	78ms	105ms	365ms	1732ms	15.9s
synthetic (string inside object)	66ms	71ms	78ms	516ms	1824ms	10.5s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	60ms	65ms	76ms	243ms	356ms	14.3s
article (body)	13ms	18ms	21ms	216ms	322ms	5.9s
article (string inside object)	57ms	59ms	64ms	196ms	296ms	8.7s
article (string inside array)	69ms	72ms	83ms	316ms	1078ms	9.8s
recipe (name)	34ms	37ms	58ms	76ms	9ms	9.3s
recipe (description)	31ms	32ms	36ms	67ms	5ms	6.0s
recipe (instructions)	6ms	7ms	9ms	10ms	0ms	3.2s
synthetic (title)	72ms	76ms	85ms	312ms	1563ms	15.8s
synthetic (string inside object)	66ms	74ms	81ms	466ms	1760ms	10.5s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

snorrees

Oh wow, great lift Rob, thank you!

I'll be happy to lift you screenshots into the other PR when this is merge, and release a new tagged-release

…tudio-style quote formatting

robinpyon requested a review from a team as a code owner October 22, 2024 16:45

robinpyon requested review from rexxars and removed request for a team October 22, 2024 16:45

robinpyon requested review from snorrees and EoinFalconer October 22, 2024 16:45

vercel bot deployed to Preview – test-next-studio October 22, 2024 16:49 View deployment

vercel bot deployed to Preview – test-compiled-studio October 22, 2024 16:52 View deployment

snorrees approved these changes Oct 22, 2024

View reviewed changes

snorrees force-pushed the create-integration branch from cfa2c71 to 8f076aa Compare October 22, 2024 18:12

snorrees requested a review from a team as a code owner October 22, 2024 18:12

robinpyon added 4 commits October 22, 2024 20:41

fix: updated SVG, minor copy and layout changes

b3a6016

fix: allow document banner popover to be closed with ESC

9ccf9eb

fix: display 'untitled' document title fallback when unlinking, use s…

c50364d

…tudio-style quote formatting

fix: tweak banner border

d282724

snorrees force-pushed the create-integration-layout-updates branch from 22456b2 to d282724 Compare October 22, 2024 18:41

snorrees merged commit 8f2cf38 into create-integration Oct 22, 2024
39 of 44 checks passed

snorrees deleted the create-integration-layout-updates branch October 22, 2024 18:42

vercel bot deployed to Preview – performance-studio October 22, 2024 18:45 View deployment

vercel bot deployed to Preview – page-building-studio October 22, 2024 18:45 View deployment

vercel bot deployed to Preview – test-studio October 22, 2024 18:46 View deployment

vercel bot deployed to Preview – test-next-studio October 22, 2024 18:50 View deployment

vercel bot deployed to Preview – test-compiled-studio October 22, 2024 18:53 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: various layout + copy updates #7656

fix: various layout + copy updates #7656

robinpyon commented Oct 22, 2024

vercel bot commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 22, 2024 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

snorrees left a comment

fix: various layout + copy updates #7656

fix: various layout + copy updates #7656

Conversation

robinpyon commented Oct 22, 2024

Changes

vercel bot commented Oct 22, 2024 • edited Loading

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024 • edited Loading

github-actions bot commented Oct 22, 2024 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

snorrees left a comment

Choose a reason for hiding this comment

vercel bot commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 22, 2024 •

edited

Loading