Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): add release layering foundations #7665

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Oct 24, 2024

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:44pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:44pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:44pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:44pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:44pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 8:44pm

@juice49 juice49 force-pushed the feat/corel-180/release-layering branch from 16a2f63 to fcd648a Compare October 24, 2024 13:33
@juice49 juice49 force-pushed the feat/corel-180/release-layering branch from fcd648a to 2589a0e Compare October 24, 2024 13:45
@juice49 juice49 force-pushed the feat/corel-180/release-layering branch from 2589a0e to a523621 Compare October 24, 2024 15:45
Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Component Testing Report Updated Oct 24, 2024 8:39 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 38s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 34s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 45s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 40s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 53s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Oct 24, 2024

⚡️ Editor Performance Report

Updated Thu, 24 Oct 2024 20:50:38 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.7 efps (60ms) 12.8 efps (78ms) +18ms (+30.0%) 🔴
article (body) 59.5 efps (17ms) 56.5 efps (18ms) +1ms (+5.4%)
article (string inside object) 17.9 efps (56ms) 13.7 efps (73ms) +17ms (+30.4%) 🔴
article (string inside array) 14.5 efps (69ms) 11.4 efps (88ms) +19ms (+27.5%) 🔴
recipe (name) 30.3 efps (33ms) 20.2 efps (50ms) +17ms (+50.0%) 🔴
recipe (description) 34.5 efps (29ms) 21.3 efps (47ms) +18ms (+62.1%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (7ms) +1ms (-/-%)
synthetic (title) 14.7 efps (68ms) 5.9 efps (171ms) +103ms (+150.7%) 🔴
synthetic (string inside object) 15.4 efps (65ms) 6.1 efps (164ms) +99ms (+152.3%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 60ms 66ms 78ms 233ms 411ms 13.1s
article (body) 17ms 19ms 22ms 197ms 238ms 5.7s
article (string inside object) 56ms 61ms 72ms 332ms 497ms 8.9s
article (string inside array) 69ms 72ms 90ms 374ms 1196ms 9.8s
recipe (name) 33ms 36ms 54ms 106ms 4ms 8.8s
recipe (description) 29ms 30ms 34ms 142ms 27ms 6.2s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.2s
synthetic (title) 68ms 72ms 76ms 178ms 1285ms 14.8s
synthetic (string inside object) 65ms 68ms 80ms 558ms 1346ms 10.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 78ms 84ms 101ms 388ms 2693ms 16.0s
article (body) 18ms 20ms 29ms 227ms 465ms 6.2s
article (string inside object) 73ms 79ms 101ms 330ms 2511ms 11.2s
article (string inside array) 88ms 93ms 105ms 334ms 3058ms 12.2s
recipe (name) 50ms 52ms 76ms 122ms 920ms 10.8s
recipe (description) 47ms 49ms 54ms 94ms 734ms 8.0s
recipe (instructions) 7ms 8ms 10ms 32ms 0ms 3.3s
synthetic (title) 171ms 185ms 351ms 1016ms 11028ms 27.9s
synthetic (string inside object) 164ms 174ms 189ms 612ms 9268ms 20.2s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant