Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: resolving typo; using setPerspectiveFromRelease for usePerspective #7670

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

jordanl17
Copy link
Member

…pective

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 4:20pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 4:20pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 4:20pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 4:20pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 4:20pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 4:20pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Component Testing Report Updated Oct 24, 2024 4:18 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 10s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 45s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 43s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 38s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 55s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Oct 24, 2024

⚡️ Editor Performance Report

Updated Thu, 24 Oct 2024 16:29:55 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.7 efps (60ms) 12.9 efps (78ms) +18ms (+29.2%) 🔴
article (body) 56.2 efps (18ms) 61.3 efps (16ms) -1ms (-8.4%)
article (string inside object) 17.5 efps (57ms) 13.6 efps (74ms) +17ms (+28.9%) 🔴
article (string inside array) 14.5 efps (69ms) 11.2 efps (89ms) +20ms (+29.0%) 🔴
recipe (name) 30.3 efps (33ms) 20.4 efps (49ms) +16ms (+48.5%) 🔴
recipe (description) 33.3 efps (30ms) 21.7 efps (46ms) +16ms (+53.3%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.5 efps (69ms) 6.0 efps (167ms) +98ms (+142.0%) 🔴
synthetic (string inside object) 14.9 efps (67ms) 6.3 efps (160ms) +93ms (+138.8%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 60ms 66ms 81ms 208ms 398ms 13.0s
article (body) 18ms 20ms 25ms 216ms 319ms 6.1s
article (string inside object) 57ms 60ms 70ms 124ms 394ms 9.0s
article (string inside array) 69ms 74ms 84ms 325ms 1071ms 9.8s
recipe (name) 33ms 36ms 54ms 90ms 22ms 9.4s
recipe (description) 30ms 31ms 34ms 55ms 0ms 5.9s
recipe (instructions) 6ms 8ms 8ms 21ms 0ms 3.2s
synthetic (title) 69ms 73ms 81ms 393ms 1543ms 15.3s
synthetic (string inside object) 67ms 70ms 77ms 169ms 1185ms 9.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 78ms 83ms 118ms 352ms 2658ms 15.8s
article (body) 16ms 18ms 26ms 203ms 440ms 5.8s
article (string inside object) 74ms 76ms 85ms 356ms 2338ms 10.9s
article (string inside array) 89ms 95ms 105ms 381ms 3367ms 12.6s
recipe (name) 49ms 51ms 54ms 100ms 833ms 11.0s
recipe (description) 46ms 47ms 50ms 82ms 722ms 7.7s
recipe (instructions) 6ms 8ms 9ms 24ms 0ms 3.3s
synthetic (title) 167ms 175ms 186ms 822ms 9066ms 25.0s
synthetic (string inside object) 160ms 173ms 187ms 872ms 9156ms 20.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant