Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reducer action to update perspective for stack #7675

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

jordanl17
Copy link
Member

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 11:49am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 11:49am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 11:49am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 11:49am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 11:49am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 11:49am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 25, 2024

Component Testing Report Updated Oct 25, 2024 11:44 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 39s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 9s 2 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 38s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 45s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 38s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 52s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Oct 25, 2024

⚡️ Editor Performance Report

Updated Fri, 25 Oct 2024 11:56:51 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.8 efps (60ms) 12.5 efps (80ms) +21ms (+34.5%) 🔴
article (body) 63.3 efps (16ms) 59.5 efps (17ms) +1ms (+6.3%)
article (string inside object) 18.5 efps (54ms) 13.7 efps (73ms) +19ms (+35.2%) 🔴
article (string inside array) 15.0 efps (67ms) 11.0 efps (91ms) +25ms (+36.8%) 🔴
recipe (name) 30.3 efps (33ms) 20.0 efps (50ms) +17ms (+51.5%) 🔴
recipe (description) 34.5 efps (29ms) 21.5 efps (47ms) +18ms (+60.3%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.7 efps (68ms) 5.8 efps (171ms) +103ms (+151.5%) 🔴
synthetic (string inside object) 15.9 efps (63ms) 6.3 efps (158ms) +95ms (+150.0%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 60ms 63ms 76ms 202ms 447ms 13.9s
article (body) 16ms 19ms 31ms 225ms 385ms 5.7s
article (string inside object) 54ms 56ms 63ms 142ms 448ms 8.6s
article (string inside array) 67ms 71ms 80ms 321ms 951ms 9.6s
recipe (name) 33ms 36ms 74ms 98ms 28ms 8.9s
recipe (description) 29ms 31ms 34ms 64ms 3ms 5.9s
recipe (instructions) 6ms 9ms 9ms 23ms 0ms 3.3s
synthetic (title) 68ms 76ms 81ms 182ms 1334ms 15.1s
synthetic (string inside object) 63ms 66ms 77ms 323ms 1050ms 9.7s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 80ms 92ms 113ms 259ms 2489ms 16.4s
article (body) 17ms 20ms 24ms 123ms 457ms 6.1s
article (string inside object) 73ms 79ms 87ms 358ms 2470ms 11.0s
article (string inside array) 91ms 96ms 105ms 371ms 3309ms 12.8s
recipe (name) 50ms 52ms 56ms 94ms 841ms 11.0s
recipe (description) 47ms 50ms 51ms 79ms 771ms 7.8s
recipe (instructions) 6ms 8ms 9ms 23ms 0ms 3.3s
synthetic (title) 171ms 185ms 294ms 590ms 10078ms 27.6s
synthetic (string inside object) 158ms 160ms 176ms 858ms 8710ms 19.5s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant