Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supporting toggling perspective layer visibility #7685

Draft
wants to merge 6 commits into
base: corel
Choose a base branch
from

Conversation

jordanl17
Copy link
Member

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 8:12pm
performance-studio 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 8:12pm
studio-workshop 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 8:12pm
test-compiled-studio 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 8:12pm
test-next-studio 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 8:12pm
test-studio 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 8:12pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 28, 2024

Component Testing Report Updated Oct 28, 2024 7:58 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 40s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 42s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 47s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 43s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 54s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Oct 28, 2024

⚡️ Editor Performance Report

Updated Mon, 28 Oct 2024 20:12:49 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.5 efps (61ms) 12.2 efps (82ms) +22ms (+35.5%) 🔴
article (body) 54.9 efps (18ms) 53.3 efps (19ms) +1ms (+3.0%)
article (string inside object) 17.9 efps (56ms) 12.5 efps (80ms) +24ms (+42.9%) 🔴
article (string inside array) 14.3 efps (70ms) 10.3 efps (97ms) +27ms (+38.6%) 🔴
recipe (name) 27.8 efps (36ms) 19.2 efps (52ms) +16ms (+44.4%) 🔴
recipe (description) 31.3 efps (32ms) 20.0 efps (50ms) +18ms (+56.3%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (7ms) +1ms (-/-%)
synthetic (title) 14.3 efps (70ms) 5.7 efps (177ms) +107ms (+152.1%) 🔴
synthetic (string inside object) 14.4 efps (70ms) 5.9 efps (169ms) +99ms (+142.4%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 61ms 72ms 89ms 121ms 441ms 13.3s
article (body) 18ms 21ms 27ms 188ms 184ms 5.8s
article (string inside object) 56ms 58ms 68ms 293ms 490ms 9.0s
article (string inside array) 70ms 78ms 89ms 340ms 1140ms 10.1s
recipe (name) 36ms 39ms 62ms 78ms 33ms 9.1s
recipe (description) 32ms 34ms 40ms 64ms 0ms 6.2s
recipe (instructions) 6ms 9ms 10ms 37ms 0ms 3.4s
synthetic (title) 70ms 73ms 79ms 305ms 1660ms 15.9s
synthetic (string inside object) 70ms 75ms 79ms 336ms 1409ms 10.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 82ms 91ms 129ms 303ms 3777ms 17.7s
article (body) 19ms 23ms 60ms 361ms 868ms 7.4s
article (string inside object) 80ms 89ms 128ms 343ms 3715ms 13.6s
article (string inside array) 97ms 110ms 273ms 380ms 5293ms 15.4s
recipe (name) 52ms 59ms 198ms 246ms 2627ms 14.2s
recipe (description) 50ms 58ms 88ms 214ms 2425ms 10.7s
recipe (instructions) 7ms 9ms 10ms 25ms 0ms 3.7s
synthetic (title) 177ms 195ms 464ms 952ms 12268ms 30.7s
synthetic (string inside object) 169ms 181ms 215ms 1005ms 11264ms 24.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant