[EXPB-2582](https://jira.tools.sap/browse/EXPB-2582). Merge join does…

… not filter out null values on left side Signed-off-by: Corvin Kuebler <[email protected]>
sap-contributions · Jul 26, 2024 · 6f3551d · 6f3551d
1 parent 9321bbc
commit 6f3551d
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java b/core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java
@@ -435,7 +435,7 @@ public static EnumerableMergeJoin create(RelNode left, RelNode right,
     BlockBuilder builder = new BlockBuilder();
     final Result leftResult =
         implementor.visitChild(this, 0, (EnumerableRel) left, pref);
-    final Expression leftExpression =
+    Expression leftExpression =
         builder.append("left", leftResult.block);
     final ParameterExpression left_ =
         Expressions.parameter(leftResult.physType.getJavaRowType(), "left");
@@ -493,19 +493,16 @@ public static EnumerableMergeJoin create(RelNode left, RelNode right,
     }
     final RelCollation collation = RelCollations.of(fieldCollations);
     final Expression comparator = leftKeyPhysType.generateMergeJoinComparator(collation);
-
     return implementor.result(
         physType,
         builder.append(
             Expressions.call(
                 BuiltInMethod.MERGE_JOIN.method,
                 Expressions.list(
-                    Expressions.call(BuiltInMethod.MERGE_JOIN_NOT_NULL_ENUMERABLE.method, leftExpression,
-                        Expressions.lambda(
-                            leftKeyPhysType.record(leftExpressions), left_)),
+                    leftExpression,
                     Expressions.call(BuiltInMethod.MERGE_JOIN_NOT_NULL_ENUMERABLE.method, rightExpression,
                         Expressions.lambda(
-                          rightKeyPhysType.record(rightExpressions), right_)),
+                            rightKeyPhysType.record(rightExpressions), right_)),
                     Expressions.lambda(
                         leftKeyPhysType.record(leftExpressions), left_),
                     Expressions.lambda(