Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mariadb] remove user and password from readyness and lifeness probes #7231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mutax
Copy link
Contributor

@mutax mutax commented Oct 11, 2024

With the credentials for the root user present in /root/.my.cnf we do not need to give them as parameters for the probes, avoiding problems with shell escaping and showing passwords in the processlist of the k8s nodes.

With the credentials for the root user present in /root/.my.cnf
we do not need to give them as parameters for the probes, avoiding
problems with shell escaping and showing passwords in the processlist
of the k8s nodes.
@businessbean
Copy link
Contributor

What about just using the ccroot user for these kind of internal connections? #6297

@mutax
Copy link
Contributor Author

mutax commented Oct 17, 2024

What about just using the ccroot user for these kind of internal connections? #6297

The probes will use whatever credentials are set in the root users config file, so if we add the ccroot user there instead of root that would work as well. In any case the password should not be present in any commandline/process list. So when changing to a different user we should come up with another solution anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants