nova/flavors: Add KVM v1 (Cascade-Lake) flavors #7274
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As agreed in ADR core/nova/0008 "KVM flavor naming scheme" the KVM flavors (and eventually, but not in this change, the VMware flavors too) gain a new hypervisor field after the g/c/m purpose field. It's "k" for KVM/Qemu (and will be "v" for VMware). Also the flavors will be suffixed with a "v1" hardware generation number for Cascade Lake right away. So, the KVM counterpart for "g_c4_m16" is named "g_k_c4_m16_v1". A per-region config flag `kvm_enabled` is introduced, defaulting to false, to allow per-region enablement of KVM flavors.
grandchild
force-pushed
the
i533984/flavors/kvm
branch
from
50fac06
to
e862f2c
Compare
|
Instead of the |
fwiesel
reviewed
Oct 18, 2024
| @@ -33,3 +35,13 @@ extra_specs: | |||
| vmware_hana_exclusive: | |||
| <<: *vmware_common | |||
| "trait:CUSTOM_HANA_EXCLUSIVE_HOST": "required" | |||
| kvm_common: &kvm_common | |||
| "capabilities:hypervisor_type": "QEMU" | |||
| "hw:mem_page_size": "large" | |||
There was a problem hiding this comment.
That particular flag is still in discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed in ADR core/nova/0008 "KVM flavor naming scheme" the KVM flavors (and eventually, but not in this change, the VMware flavors too) gain a new hypervisor field after the g/c/m purpose field. It's "k" for KVM/Qemu (and will be "v" for VMware).
Also the flavors will be suffixed with a "v1" hardware generation number for Cascade Lake right away.
So, the KVM counterpart for "g_c4_m16" is named "g_k_c4_m16_v1".
A per-region config flag
kvm_enabledis introduced, defaulting to false, to allow per-region enablement of KVM flavors.Note that there are a few flavors still commented out, those are legacy flavors with the AWS naming schema that are still in use, and we should decide whether we still want some of these or close variants thereof.