Int conversion checks #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I obviously have this wrong, because using 32, it's building on 64, and then another type conversion. But I have a local issue with golangci running, so I'm going to fix that first so I can actually test locally before pushing it up. |
|
alright, fixed golangci lint locally. If I ever see this again, golangci/golangci-lint#4909 |
|
And this check in gosec is broken in multiple ways, reading through the issues a lot of people are setting them to be ignored, but it does seem somewhat sane to have. Either way, this PR is now a mess, and I'll just start from scratch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.