Add small improvements #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M1troll
requested review from
ron8mcr,
TheSuperiorStanislav and
NikAzanov
as code owners
ron8mcr
approved these changes
May 24, 2024
| wait_until_clickable: Wait until the element is clickable before | ||
| clicking, or not (default `True`). | ||
|
|
||
| """ | ||
| if wait_until_clickable: | ||
| self.wait_until_clickable() | ||
| if scroll_to: |
There was a problem hiding this comment.
I think it's better to change order of wait and click.
Consider case when button is not visible on a screen (need to scroll) and not clickable.
If wait condition will fail, it would be nice to make a screenshot to investigate issue later. But screenshot won't show desired button because scroll not applied yet
TheSuperiorStanislav
approved these changes
May 24, 2024
There is often a situation when you need to add `[contains(., text)]` to an already ready locator, and for this you have to use `extend_query`. So we decided to put it into a separate method.
M1troll
force-pushed
the
feature/add-small-improvements
branch
from
8d4f01c
to
458ba3c
Compare
M1troll
force-pushed
the
feature/add-small-improvements
branch
from
4855d4a
to
e114515
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PageDidNotLoadedErrorXPathLocator