Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rgb, rgba, hsl, and hsla specs match the style guide #1394

Merged
merged 3 commits into from
Jun 2, 2019
Merged

Make rgb, rgba, hsl, and hsla specs match the style guide #1394

merged 3 commits into from
Jun 2, 2019

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented May 31, 2019 •
edited
Loading

Partially addresses #1001

@nex3 nex3 requested a review from jathak May 31, 2019 12:02
jathak
jathak approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from a few comments

spec/core_functions/color/hsl/one_arg/alpha.hrx Outdated Show resolved Hide resolved
spec/core_functions/color/hsl/three_args/w3c.hrx Outdated Show resolved Hide resolved
spec/core_functions/color/hsla/four_args/clamped.hrx Outdated Show resolved Hide resolved
spec/core_functions/color/hsla/three_args/w3c.hrx Outdated Show resolved Hide resolved
@nex3 nex3 merged commit 7696d24 into master Jun 2, 2019
@nex3 nex3 deleted the rgb-hsl-style branch June 2, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak jathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @jathak