Implement new rule no-excessive-empty-lines (fixes #1015)
#1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make it accept some parameters
|
Is there anything I can do to fix the failing Appveyor build? I can't see any logs so I have no clue why it's failing. Could this be a problem with the CI setup, or are my changes causing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do the changes you have made achieve?
Implements new rule
no-excessive-empty-lines. The rule is configurable to allow or disallow consecutive empty lines, and blank lines at the start and end of blocks, respectively.A couple of minor quality-of-life type improvements have also been included in the PR, since I couldn't keep my hands off of them (commits 9653690 and 982ac82).
Are there any new warning messages?
No.
Have you written tests?
Yes.
Have you included relevant documentation
Yes.
Which issues does this resolve?
#1015 #1093 #1073
<DCO 1.1 Signed-off-by: Filip Haglund [email protected]>