Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new device G #1380

Merged
merged 10 commits into from
Jun 14, 2024
Merged

Add new device G #1380

merged 10 commits into from
Jun 14, 2024

Conversation

VadimZezyotkoATP
Copy link
Member

@VadimZezyotkoATP VadimZezyotkoATP commented May 22, 2024 •
edited by KirillGutyrchik
Loading

Fixes #1360.

Добавлено новое устройтсво G (блок питания).

@KirillGutyrchik KirillGutyrchik requested review from KirillGutyrchik and removed request for idzm May 22, 2024 09:31
@KirillGutyrchik KirillGutyrchik added the safe to test Pull request is safe to build and test label May 22, 2024
KirillGutyrchik
KirillGutyrchik requested changes May 22, 2024
View reviewed changes
Copy link
Member

@KirillGutyrchik KirillGutyrchik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно добавить тесты (пример).
А также документацию.

@KirillGutyrchik KirillGutyrchik added safe to test Pull request is safe to build and test and removed safe to test Pull request is safe to build and test labels May 27, 2024
@VadimZezyotkoATP VadimZezyotkoATP added safe to test Pull request is safe to build and test and removed safe to test Pull request is safe to build and test labels May 28, 2024
@KirillGutyrchik KirillGutyrchik removed the safe to test Pull request is safe to build and test label Jun 6, 2024
@KirillGutyrchik KirillGutyrchik added the safe to test Pull request is safe to build and test label Jun 6, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@idzm idzm enabled auto-merge June 14, 2024 07:01
@idzm idzm added this pull request to the merge queue Jun 14, 2024
Merged via the queue into savushkin-r-d:master with commit b121af4 Jun 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KirillGutyrchik KirillGutyrchik KirillGutyrchik approved these changes

@idzm idzm idzm approved these changes

Assignees

@VadimZezyotkoATP VadimZezyotkoATP

Labels
safe to test Pull request is safe to build and test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Добавление нового устройства (блока питания) с IO-Link
3 participants
@VadimZezyotkoATP @idzm @KirillGutyrchik