Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Eplan pages with IO-modules importing from main.wago.plua #1417

Merged
merged 21 commits into from
Aug 29, 2024
Merged

Generate Eplan pages with IO-modules importing from main.wago.plua #1417

merged 21 commits into from
Aug 29, 2024

Conversation

KirillGutyrchik
Copy link
Member

Fixes #1398.

Добавлена функциональность, позволяющая импортировать старые проекты из main.wago.plua, генерируя страницы EPLAN с модулями.

@KirillGutyrchik KirillGutyrchik added the enhancement New feature or request label Aug 7, 2024
@KirillGutyrchik KirillGutyrchik self-assigned this Aug 7, 2024
@KirillGutyrchik KirillGutyrchik marked this pull request as ready for review August 15, 2024 05:54
@KirillGutyrchik KirillGutyrchik marked this pull request as draft August 15, 2024 08:47
@KirillGutyrchik KirillGutyrchik marked this pull request as ready for review August 16, 2024 07:36
idzm
idzm requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@idzm idzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо убрать данные замечания - https://sonarcloud.io/project/issues?id=savushkin-r-d_EasyEPLANner&pullRequest=1417&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true.

idzm
idzm requested changes Aug 27, 2024
View reviewed changes
src/Main/ImportIcpWagoModulesAction.cs Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@idzm idzm added this pull request to the merge queue Aug 29, 2024
Merged via the queue into savushkin-r-d:master with commit fb0d23f Aug 29, 2024
4 checks passed
@KirillGutyrchik KirillGutyrchik mentioned this pull request Sep 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 2, 2024
@KirillGutyrchik
Fix clamps naming (#1423)
51ef62c 
Связано с #1417.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadimZezyotkoATP VadimZezyotkoATP VadimZezyotkoATP approved these changes

@idzm idzm idzm approved these changes

Assignees

@KirillGutyrchik KirillGutyrchik

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@KirillGutyrchik @idzm @VadimZezyotkoATP