Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inheritance "valve_DO2" #598

Merged
merged 7 commits into from
Aug 3, 2023
Merged

Fix inheritance "valve_DO2" #598

merged 7 commits into from
Aug 3, 2023

Conversation

NogameNo-life
Copy link
Collaborator

No description provided.

@NogameNo-life NogameNo-life added safe to test Safe to being tested and removed safe to test Safe to being tested labels Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (98b228b) 31.73% compared to head (547ceed) 31.75%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
+ Coverage   31.73%   31.75%   +0.02%     
==========================================
  Files          62       62              
  Lines       23561    23561              
==========================================
+ Hits         7476     7482       +6     
+ Misses      16085    16079       -6
Files Changed Coverage Δ
PAC/common/PAC_dev.cpp 50.06% <ø> (+0.06%) ⬆️
PAC/common/PAC_dev.h 41.26% <100.00%> (+1.90%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NogameNo-life NogameNo-life added safe to test Safe to being tested and removed safe to test Safe to being tested labels Aug 1, 2023
@NogameNo-life NogameNo-life added safe to test Safe to being tested and removed safe to test Safe to being tested labels Aug 1, 2023
@idzm idzm changed the title Change inheritance valve_DO2 Fix inheritance "valve_DO2" Aug 1, 2023
@NogameNo-life NogameNo-life added safe to test Safe to being tested and removed safe to test Safe to being tested labels Aug 2, 2023
@NogameNo-life NogameNo-life added safe to test Safe to being tested and removed safe to test Safe to being tested labels Aug 3, 2023
@NogameNo-life NogameNo-life added safe to test Safe to being tested and removed safe to test Safe to being tested labels Aug 3, 2023
@NogameNo-life NogameNo-life added safe to test Safe to being tested and removed safe to test Safe to being tested labels Aug 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@AlexandrBehunkov AlexandrBehunkov merged commit 8b726d0 into savushkin-r-d:master Aug 3, 2023
13 checks passed
@NogameNo-life NogameNo-life deleted the dev_valve_DO2 branch August 3, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandrBehunkov AlexandrBehunkov AlexandrBehunkov approved these changes

@idzm idzm idzm approved these changes

@rartem rartem Awaiting requested review from rartem rartem is a code owner

Assignees
No one assigned
Labels
safe to test Safe to being tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NogameNo-life @idzm @AlexandrBehunkov