Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of maintainability #783

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

Lenonim
Copy link
Collaborator

@Lenonim Lenonim commented Oct 16, 2024

No description provided.

@Lenonim Lenonim self-assigned this Oct 16, 2024
@Lenonim Lenonim added enhancement New feature or request safe to test Safe to being tested labels Oct 16, 2024
@Lenonim Lenonim added safe to test Safe to being tested and removed safe to test Safe to being tested labels Oct 16, 2024
@Lenonim Lenonim added safe to test Safe to being tested and removed safe to test Safe to being tested labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 53.65854% with 76 lines in your changes missing coverage. Please review.

Project coverage is 42.11%. Comparing base (db162e5) to head (7c3c786).

Files with missing lines Patch % Lines
PAC/common/device/valve.cpp 34.09% 29 Missing ⚠️
PAC/common/modbus_client.cpp 36.84% 24 Missing ⚠️
PAC/common/device/device.cpp 51.85% 13 Missing ⚠️
PAC/common/cip_tech_def.cpp 16.66% 5 Missing ⚠️
PAC/common/modbus_serv.cpp 0.00% 4 Missing ⚠️
PAC/common/tech_def.cpp 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
+ Coverage   41.34%   42.11%   +0.77%     
==========================================
  Files          69       69              
  Lines       26269    26070     -199     
  Branches     3266     3243      -23     
==========================================
+ Hits        10861    10980     +119     
+ Misses      15408    15090     -318     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lenonim Lenonim added safe to test Safe to being tested and removed safe to test Safe to being tested labels Oct 16, 2024
@Lenonim Lenonim added safe to test Safe to being tested and removed safe to test Safe to being tested labels Oct 16, 2024
@Lenonim Lenonim added safe to test Safe to being tested and removed safe to test Safe to being tested labels Oct 17, 2024
@Lenonim Lenonim added safe to test Safe to being tested and removed safe to test Safe to being tested labels Oct 17, 2024
@Lenonim Lenonim added safe to test Safe to being tested and removed safe to test Safe to being tested labels Oct 17, 2024
@idzm idzm removed the safe to test Safe to being tested label Oct 18, 2024
@idzm idzm added safe to test Safe to being tested and removed safe to test Safe to being tested labels Nov 1, 2024
@idzm idzm added safe to test Safe to being tested and removed safe to test Safe to being tested labels Nov 1, 2024
@idzm idzm added safe to test Safe to being tested and removed safe to test Safe to being tested labels Nov 1, 2024
@idzm idzm added safe to test Safe to being tested and removed safe to test Safe to being tested labels Nov 11, 2024
@idzm idzm added safe to test Safe to being tested and removed safe to test Safe to being tested labels Nov 11, 2024
@idzm idzm added safe to test Safe to being tested and removed safe to test Safe to being tested labels Nov 12, 2024
@idzm idzm added safe to test Safe to being tested and removed safe to test Safe to being tested labels Nov 13, 2024
@idzm idzm added safe to test Safe to being tested and removed safe to test Safe to being tested labels Nov 14, 2024
@idzm idzm added safe to test Safe to being tested and removed safe to test Safe to being tested labels Nov 14, 2024
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
38.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request safe to test Safe to being tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants