Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in version range handling #362

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix bug in version range handling #362

wants to merge 1 commit into from

Conversation

BITespresso
Copy link

@typesafe-tools
Copy link

To validate this pull request against other sbt modules, please visit this link.

@BITespresso BITespresso mentioned this pull request Jan 12, 2021
Open
eed3si9n
eed3si9n reviewed Jan 12, 2021
View reviewed changes
core/src/test/scala/sbt/librarymanagement/VersionRangeSpec.scala
it should "strip [1.0,2.0] to None" in stripTo("[1.0,2.0]", None)
it should "strip [1.0,2.0] to 2.0" in stripTo("[1.0,2.0]", Some("2.0"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upper bound could be a non-existent version, so I think it's usually better to prioritize to the lower bound to keep things within the graph.

@eed3si9n
Copy link
Member

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BITespresso @typesafe-tools @eed3si9n @bergermi