Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and apply scalafmt #74

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Add and apply scalafmt #74

merged 2 commits into from
Jan 22, 2024

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Jan 22, 2024

Since there are no other open PR's I think that now is a good time to add and apply scalafmt. I used a pretty standard formatter configuration that is also the same in other sbt community plugins.

@mkurz When you merge this PR either do a merge commit or rebase + merge but not squash and merge. I want to add the Apply scalafmt commit hash to a .git-blame-ignore-revs file so it doesn't appear in git blame. Also once the PR is merged you can add the Code is formatted github action as a status check for the main branch on PR's so you cannot merge unformatted code.

@mkurz mkurz merged commit 85d977a into sbt:main Jan 22, 2024
6 checks passed
@mdedetrich mdedetrich deleted the add-and-apply-scalafmt branch January 22, 2024 22:23
@mkurz
Copy link
Member

mkurz commented Jan 22, 2024

Done, also added the status check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants