-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add JDK 23 to build tool table #3082
base: main
Are you sure you want to change the base?
Conversation
We only run CI tests on JDK 17 (https://www.scala-sbt.org/1.x/docs/Setup.html). If anything later worked, it's purely by lucky accident, but people are free to choose whatever. |
For sbt, would it be an improvement to add CI tests for all combination of major OS (Ubuntu, Mac, Windows) & LTS Java version? I use sbt with Java 21 locally and can confirm it works quite well. Some minor change in Even if some of the newly added tests fail, given the massive userbase of sbt, the CI failures would likely be real issue that needs to be addressed. |
I've created sbt/sbt#7731. Let's discuss there. |
for the purposes of this web page, it's enough that there isn't some obvious showstopper that most people will hit — particularly since 23 isn't LTS |
works for me on a sample repo, anyway. if we discover otherwise we can change it
@lefou what should I put for mill? |
Mill has no dedicated Java 23 test suite. Our full CI doesn't succeed on Java 23 due to some tests exercising older Scala versions that are known to be incompatible with Java 21 and above. But Mill |
I just checked, I can build Mill's own code base ( |
Co-authored-by: Tobias Roeser <[email protected]>
thank you @lefou leaving as draft until we hear from Piotr (there's no big rush) |
ping @Gedochao |
Sorry for the late answer, I missed this somehow.
@SethTisue that would make sense, but I suspect you'd need the relevant minimum
The average user would use a native launcher, which wouldn't care what version of Java is installed for running the CLI itself. When building projects with a build server (as in, Bloop), Java 17+ is required. However, Scala CLI will download the appropriate JVM for Bloop as necessary, so this could be treated independently. Running user projects respects user configuration and should support Java 8+. The most recent If this is blocking this PR, we can do a separate follow-up. |
Ran some very basic tests.
I intend to add some tests to our test suite, + perhaps bump things from Java 22 to 23 on the CI, but perhaps the data above would be sufficient? |
@eed3si9n what should I put for sbt?
@lefou what should I put for mill?
@Gedochao should I add a scala-cli column?