Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish support for code coverage #14620

Closed
wants to merge 3 commits into from

Conversation

TheElectronWill
Copy link
Contributor

@TheElectronWill TheElectronWill commented Mar 4, 2022

This is a follow-up of #13880

TODO:

  • make it compile on latest main
  • cleanup phase definition (InstrumentCoverage)
  • try new, simpler strategy for handling function calls
  • handle more trees
  • see if something can be done about interpolated strings
  • avoid global state
  • test (any advice on how to replace the big "expect" file, if it's not the best solution?)

@smarter
Copy link
Member

smarter commented Mar 4, 2022

@TheElectronWill I upgraded your access level in the dotty repo to "Maintain", I believe this should let you push your changes directly into @ckipp01's branch for #13880 which should make cooperation easier.

@TheElectronWill
Copy link
Contributor Author

Wow! Thank you for your trust Guillaume :)
I'll close this PR, then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants