-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks to given priority #21305
Closed
Closed
Tweaks to given priority #21305
Commits on Jul 31, 2024
-
- Don't treat givens as higher priority than implicits. The previous logic was faulty anyway. - Drop special handling of NotGiven in prioritization. The previous logic pretended to do so, but was ineffective. - Don't use old priority in general for implicit/implicit pairs. This would make upgrading to givens a constant struggle. But do use it as a tie breaker in the case of ambiguities. - Also use owner score as a tie breaker if after all other tests we still have an ambiguity.
Configuration menu - View commit details
-
Copy full SHA for bdfb12e - Browse repository at this point
Copy the full SHA bdfb12eView commit details -
Add priority change warnings to ambiguous implicits error messages
Previously warnings were produced but not shown since at the same position we already have an ambiguity error. We now add the note to the error message.
Configuration menu - View commit details
-
Copy full SHA for 3cf4ada - Browse repository at this point
Copy the full SHA 3cf4adaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2795a50 - Browse repository at this point
Copy the full SHA 2795a50View commit details -
Apply suggestions from code review
Co-authored-by: Eugene Flesselle <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bba0db3 - Browse repository at this point
Copy the full SHA bba0db3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 462b293 - Browse repository at this point
Copy the full SHA 462b293View commit details -
Disambiguate by owner score before considering further implicit argum…
…ents This makes slick-migration-api-example work and makes the original scala-uri.scala fail. See the comment in neg/scala-uri.scala for why this is so. It also needs a change in the givens in dotty.tools.reporting.Formatting. The motivation for honoring owner score over the others is that it is often used for explicit prioritization, so we should take it into account more than other secondary criteria.
Configuration menu - View commit details
-
Copy full SHA for 3d9ce8e - Browse repository at this point
Copy the full SHA 3d9ce8eView commit details
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 62acaf1 - Browse repository at this point
Copy the full SHA 62acaf1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.