-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: delete sessionCallBlocked only by the same tab that added entry #279
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks ok, but for sure if you want to introduce this change, TTL should be adjusted in case that redirect didn't succeed.
I would set it to 5 seconds TOP. Long story short, this change is a bit risky and honestly it might break more than fix it.
const SESSION_CALL_BLOCKED_TTL = 1000 * 5;
This reverts commit 1144bf1.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 99.85% 97.10% -2.75%
==========================================
Files 14 14
Lines 668 692 +24
Branches 176 179 +3
==========================================
+ Hits 667 672 +5
- Misses 1 16 +15
- Partials 0 4 +4 ☔ View full report in Codecov by Sentry. |
Currently, since local storage is shared between tabs, other tabs can clean session-service stop switch. Added logic to save tabId to
sessionCallBlocked-cache
instead of boolean value, and clean this entry only if tabId value matches