Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS Cognito Authentication, and Jira Notifications #97

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

danmenzies-jerram
Copy link

  • Added SSL (needed for oAuth 2.0 authentication via Cognito)
  • Added new config options for cognito
  • Added relevant node packages
  • Adjusted the test-server script to allow for SSL
  • Added detailed instructions on setting up Cognito
  • Added detailed instructions on setting up Jira Notifications
  • Added placeholder config properties to the example config.tpl.json file
  • Created a Jira Project lister, to make it easier to select which project to send notifications to
  • Created test script (allows you to test a Jira config)
  • Added relevant NPM Packages

danmenzies and others added 30 commits February 13, 2019 10:36
Added Amazon Cognito oAuth using Passport
Added server start-up routine suitable for Windows x64 environments
@gka
Copy link
Member

gka commented Mar 5, 2019

hey thanks for the PRs. will try to take a look at this on the weekend.

@danmenzies-jerram
Copy link
Author

danmenzies-jerram commented Mar 6, 2019 via email

@gka
Copy link
Member

gka commented Mar 7, 2019

just a heads up, we are very likely going to introduce a simple plugin architecture for Schnack that allows adding a lot more authentication and notification methods without cluttering the core of Schnack. I will let you know once the final specifications of the plugin APIs are done.

@danmenzies-jerram
Copy link
Author

danmenzies-jerram commented Mar 20, 2019 via email

@gka
Copy link
Member

gka commented Jan 16, 2021

Hi @danmenzies-jerram,

Apologies for the ultra-long delay, but I am still very excited about your contributions. I finally got around to finish my big plugin refactoring, so now we can add lots of integrations without cluttering the Schnack core repo.

If you are still interested you can add PRs for the auth-cognito and notify-jira plugins in schnack-plugins. I promise it won't take another 20 month to review them ;-)

In the meantime I already added your ssl/https mode, which rightfully belongs to Schnack. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants