Renamed infra-tester config file #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a hidden file is less confusing as it doesn't clutter the source directories. Tools like pre-commit and other test tools follow the same approach. Also use the name "infra-tester" in the file name which clearly connects the configuration to the tool.
fwolfheimer
added
documentation
najose
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
This has been in my mind for some time now. Naming it config.yaml made it easy to conflict with any other config.yaml and that would make it impossible to use infra-tester unless users renamed the other config.yaml. Naming it .infra-tester-config.yaml sounds perfect as it follows the standard .<util>-config.yaml + makes it hidden. Thanks a lot for this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a hidden file is less confusing as it doesn't clutter the source directories. Tools like pre-commit and other test tools follow the same approach. Also use the name "infra-tester" in the file name which clearly connects the configuration to the tool.
Updated code and docs.