Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comparison function as histogram operation #762

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

gohil-jay
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the needs changelog Might need a changelog entry label Jul 1, 2022
@gohil-jay gohil-jay requested a review from henryiii July 1, 2022 03:03
@@ -337,6 +338,20 @@ def ndim(self) -> int:
"""
return self._hist.rank()

def compare(self, hist2) -> bool:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def compare(self, hist2) -> bool:
def compare(self, hist2: "Histogram") -> bool:

@gohil-jay
Copy link
Collaborator Author

Updated PR: #763

@henryiii henryiii marked this pull request as draft July 5, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Might need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants