Fix CORS error #871
Merged
Fix CORS error #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JaDogg bro Shall we merge this? |
kmehant
approved these changes
May 12, 2020
deshankoswatte
approved these changes
May 29, 2020
|
Shouldn't we allow this from some pattern? |
JaDogg
approved these changes
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CORS error was coming in flask-socketio server. This issue was fixed by allowing cors_allowed_origin to all the routes.
#870
Motivation and Context
Error was coming due to CORS policy in the flask-socketio server
How Has This Been Tested?
the console is not showing any errors anymore
Screenshots (In case of UI changes):
Types of changes
Checklist: