Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the broken logo in Readme #909

Merged
merged 2 commits into from
May 15, 2020
Merged

Fixed the broken logo in Readme #909

merged 2 commits into from
May 15, 2020

Conversation

dewanshrawat15
Copy link

@dewanshrawat15 dewanshrawat15 commented Mar 30, 2020 •
edited
Loading

Description

The Bassa logo in the README was broken. I fixed that. Also, the Contributors section in the README file was ported from HTML to standard Markdown.

Related Issue

The issue referenced is #693 and #894

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dewanshrawat15
Adding logo to Readme title
5f01a76
@dewanshrawat15
Shifting contributors section from HTML to Markdown
77d052e 
The Contributors section was designed in HTML, which was inconsistent with the standard markdown. Updated the same to keep it consistent in markdown
deshankoswatte
deshankoswatte approved these changes May 11, 2020
View reviewed changes
Copy link

@deshankoswatte deshankoswatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaDogg ,@kmehant please approve and merge.

@deshankoswatte
Copy link

Previously:

Screenshot_2020-05-11 scorelab Bassa

With fix:

Screenshot_2020-05-11 dewanshrawat15 Bassa

@kmehant kmehant requested a review from JaDogg May 11, 2020 12:16
@JaDogg JaDogg merged commit d837afc into scorelab:develop May 15, 2020
@deshankoswatte deshankoswatte mentioned this pull request May 20, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaDogg JaDogg JaDogg approved these changes

@kmehant kmehant kmehant approved these changes

@deshankoswatte deshankoswatte deshankoswatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dewanshrawat15 @deshankoswatte @JaDogg @kmehant