New labels should start 1/2 a bar-width to right #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 192 should add half a bar width to the horizontal starting position of labels in the `enter()` selection, otherwise they are incorrectly aligned with the bar during the transition.
Selbosh
commented
Jan 24, 2018
| @@ -189,7 +189,7 @@ | |||
| return d.value; | |||
| }) | |||
| .attr("text-anchor", "middle") | |||
| .attr("x", w) | |||
Selbosh
commented
Jan 24, 2018
| @@ -189,7 +189,7 @@ | |||
| return d.value; | |||
| }) | |||
| .attr("text-anchor", "middle") | |||
| .attr("x", w) | |||
| .attr("x", w + xScale.bandwidth() / 2) | |||
There was a problem hiding this comment.
Places label in centre of new (invisible) bar
|
Ah, thank you! Very good catch, and I expect you're the first person to notice this very small and fast-moving discrepancy. :-) I'm going to leave this PR open for now; I'd like to apply this, but not until the code excerpts and explanations in the book can be updated at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 192 should add half a bar width to the horizontal starting position of labels in the
enter()selection, otherwise they are incorrectly aligned with the bar during the transition.