Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add for decoding x-www-form-urlencoded data #216

Closed
wants to merge 2 commits into from
Closed

Add for decoding x-www-form-urlencoded data #216

wants to merge 2 commits into from

Conversation

mitchellwrosen
Copy link

Here ya go if you'd like it - decoding x-www-form-urlencoded request bodies a la jsonData

Copy link
Collaborator

@ocramz ocramz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ocramz
Copy link
Collaborator

ocramz commented Sep 10, 2023

@mitchellwrosen I've fixed the conflicts, now waiting for CI and we're good to merge

@ocramz ocramz self-requested a review September 24, 2023 10:11
Copy link
Collaborator

@ocramz ocramz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http-api-data import is missing.

@@ -65,6 +66,7 @@ import Network.Wai

import Numeric.Natural

import qualified Web.FormUrlEncoded as F
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just noticed that CI fails because this module is not in scope. @mitchellwrosen could you add the 'http-api-data' import in the cabal file?

@mitchellwrosen
Copy link
Author

mitchellwrosen commented Sep 25, 2023

@ocramz Sorry but I'm not sure I have the context or bandwidth to dedicate to this 5 year old PR of mine. I'm not a scotty user :(

I will note that the commit I made looks rather different than the PR in its current form.

Here is my commit: 2a7db35

I think the merge commit you made into this branch 2 weeks ago has accidentally added some unwanted stuff, somehow: 4ea5e7f

@ocramz ocramz mentioned this pull request Oct 3, 2023
3 tasks
@ocramz
Copy link
Collaborator

ocramz commented Oct 3, 2023

@mitchellwrosen apologies, I must have made a mistake while fixing conflicts. Closing this for now and resuming at #321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants