Add coverageExclude task #445
Conversation
| @@ -8,6 +8,7 @@ object ScoverageKeys { | |||
| "controls whether code instrumentation is enabled or not" | |||
| ) | |||
| lazy val coverageReport = taskKey[Unit]("run report generation") | |||
| lazy val coverageExclude = taskKey[Unit]("exclude/remove files and packages from coverage file (after the fact)") | |||
There was a problem hiding this comment.
This is the task that we add.
| @@ -192,11 +194,45 @@ object ScoverageSbtPlugin extends AutoPlugin { | |||
| sjsClassifier getOrElse "" | |||
| } | |||
|
|
|||
| private lazy val coverageExclude0 = Def.task { | |||
There was a problem hiding this comment.
This is the implementation of the task we add.
| case None => log.warn("No coverage data, skipping reports") | ||
|
|
||
| case None => | ||
| log.warn(s"No coverage data found in [$target]. Run >sbt coverage test< first.") |
There was a problem hiding this comment.
Making the warning more expressive.
| case None => | ||
| log.info("No subproject data to aggregate, skipping reports") | ||
| log.warn(s"No coverage data found to aggregate in [$target]. Run >sbt coverage test< first.") |
There was a problem hiding this comment.
Turning it into a warning (because the other log messages are warnings) and making it more expressive
| @@ -386,10 +426,10 @@ object ScoverageSbtPlugin extends AutoPlugin { | |||
| sourceRoot: File | |||
| ): Option[Coverage] = { | |||
|
|
|||
| val dataDir = crossTarget / "/scoverage-data" | |||
| val dataDir = crossTarget / "scoverage-data" | |||
There was a problem hiding this comment.
Fixing minor broken window.
Thanks for the pr @rolandtritsch, but as I mentioned in your request here I have no intention of maintaining a hack for this. Unless someone else would want to step up and maintain scoverage / sbt-scoverage I don't really have any intention of adding extra things except for bug fixes. I think this functionality should be added into dotc instead. |
|
Hi @ckipp01. I want to help. Happy to take ownership to maintain And yes. As I said above I will also open a feature request on dotty. |
|
As a matter of fact the three repos I offer to own are ...
Happy to help. |
rolandtritsch
force-pushed
the
roland/workaround-exclude
branch
from
8e9999d
to
f5d4004
Compare
|
Sorry for the delay @rolandtritsch. Working on getting you some access as I actually don't have rights to add you to the org. |
|
@rolandtritsch you should be good to go. I've got you added to the sbt team giving you access to the sbt repos. They should be set up to simply push a tag to release. |
|
Closing this for now. |
Hi @ckipp01,
this just shows/demos that and how the
coverageExcludetask works.I know it is a "hack", but it is better than nothing and it works. I just tried it it on nmesos ...
I leave it with you to decide, if you want to consider this to include it in a potential 2.1.0 release.
Note: This also needs some minor changes to scala-scoverage-plugin
Note: This PR builds on top of this one.