Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove self.now from freshness_date_parser #885

Conversation

noviluni
Copy link
Collaborator

Removes the self.now from the freshness_date_parser to make it more compatible with concurrency/threads (partial fix).

closes: #814
simplifies: #834 (as it can't be merged as-is)

fixes partially: #813, #441

@noviluni noviluni requested a review from Gallaecio February 18, 2021 07:27
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #885 (699ada7) into master (be05e0e) will decrease coverage by 0.00%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
- Coverage   98.20%   98.20%   -0.01%     
==========================================
  Files         229      229              
  Lines        2504     2501       -3     
==========================================
- Hits         2459     2456       -3     
  Misses         45       45              
Impacted Files Coverage Δ
dateparser/freshness_date_parser.py 99.01% <94.44%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be05e0e...80e6a4c. Read the comment docs.

@noviluni noviluni merged commit 12cfa6f into scrapinghub:master Feb 18, 2021
@ageorge95
Copy link

That fixed my problem of using threading and dateparser.
Thanks @noviluni 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants