Skip to content

Commit

Permalink
Merge pull request #92 from scrapy/modernize
Browse files Browse the repository at this point in the history
Bump tool versions.
  • Loading branch information
wRAR authored Sep 30, 2024
2 parents cd538a9 + 18ccbb4 commit 479a147
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ repos:
- id: black
language_version: python3
repo: https://github.com/ambv/black
rev: 24.4.0
rev: 24.8.0
- hooks:
- id: isort
language_version: python3
Expand All @@ -21,4 +21,4 @@ repos:
- flake8-docstrings
- flake8-string-format
repo: https://github.com/pycqa/flake8
rev: 7.0.0
rev: 7.1.1
4 changes: 2 additions & 2 deletions itemloaders/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ def add_value(
"""
value = self.get_value(value, *processors, re=re, **kw)
if value is None:
return
return self
if not field_name:
for k, v in value.items():
self._add_value(k, v)
Expand All @@ -244,7 +244,7 @@ def replace_value(
"""
value = self.get_value(value, *processors, re=re, **kw)
if value is None:
return
return self
if not field_name:
for k, v in value.items():
self._replace_value(k, v)
Expand Down
15 changes: 11 additions & 4 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,24 @@ commands =
[testenv:twinecheck]
basepython = python3
deps =
twine==5.0.0
build==1.2.1
twine==5.1.1
build==1.2.2
commands =
python -m build --sdist
twine check dist/*

[testenv:typing]
basepython = python3
deps =
mypy==1.10.0
types-attrs==19.1.0
mypy==1.11.2
attrs>=18.2.0
types-jmespath==1.0.2.20240106
commands =
mypy --strict --ignore-missing-imports --implicit-reexport {posargs:itemloaders tests}

[testenv:pre-commit]
basepython = python3
deps =
pre-commit
commands =
pre-commit run {posargs:--all-files}

0 comments on commit 479a147

Please sign in to comment.