Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the separator parameter added upstream to parse_qs and parse_qsl #167

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Mar 12, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #167 (6a48367) into master (a6e8c8d) will decrease coverage by 0.32%.
The diff coverage is 88.88%.

❗ Current head 6a48367 differs from pull request most recent head a8e50d2. Consider uploading reports for the commit a8e50d2 to get more accurate results

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   96.14%   95.82%   -0.33%     
==========================================
  Files           8        8              
  Lines         493      503      +10     
  Branches       92       92              
==========================================
+ Hits          474      482       +8     
- Misses          9       10       +1     
- Partials       10       11       +1     
Impacted Files Coverage Δ
w3lib/url.py 97.89% <88.88%> (-0.79%) ⬇️

@hugovk
Copy link
Contributor

hugovk commented Sep 1, 2021

#168 says:

Once merged, we can also merge #167

Time to resolve conflicts and merge this?

@Gallaecio
Copy link
Member Author

Merged with GitHub’s UI, crossing fingers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants