chore(deps): update dependency json to v10 [security] #327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^9.0.4
->^10.0.0
GitHub Vulnerability Alerts
CVE-2020-7712
This affects the package json before 10.0.0. It is possible to inject arbritary commands using the parseLookup function.
Release Notes
trentm/json (json)
v10.0.0
Compare Source
Backward incompatible and security-related change to parsing "lookup" strings.
This version restricts the supported syntax for bracketed "lookup"
strings to fix a possible
vulnerability (CVE-2020-7712). With a carefully crafted lookup string,
command injection was possible. See
#144 for a repro. If you use
json
(the CLI or as a node.js module) and run arbitrary user-providedstrings as a "lookup", then you should upgrade.
For the
json
CLI, a "lookup" string is the 'foo' in:which allows you to lookup fields on the given JSON, e.g.:
If one of the lookup fields isn't a valid JS identifier, then the JS array
notation is supported:
Before this change,
json
would effectively exec the string between thebrackets as JS code such that things like the following were possible:
This change limits supported bracket syntax in lookups to a simple quoted
string:
Otherwise generating an error of the form:
Configuration
📅 Schedule: Branch creation - "" in timezone America/New_York, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.