Remove calls to updateDrawableSkinIdRotationCenter #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
force-pushed
the
dont-update-rotation-center
branch
from
53437b8
to
a434bc5
Compare
adroitwhiz
commented
Jan 30, 2020
|
Make sure you test this after merging scratchfoundation/scratch-render#561 -- there are some existing rotation-center-related issues in the codebase that may interfere with testing. |
fsih
reviewed
Mar 26, 2020
This was referenced Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR removes calls to
Renderer.updateDrawableSkinIdRotationCenter, replacing them with calls toRenderer.updateDrawableSkinId.It also fixes
loadBitmap_to properly set bitmap costumes' rotation centers.Reason for Changes
Everywhere in the current codebase, updating a drawable's rotation center should do nothing.
It appears to be a vestige of the time when rotation centers belonged to
Drawables and notSkins (the code to update drawables' rotation centers was added Oct 9, 2016,Skins were introduced Dec 28, 2016).Fixing a long-standing bug with vector costumes in
scratch-render(see scratchfoundation/scratch-render#550 for a detailed writeup) involves changes to the way vector costumes' rotation centers are set; notably, changing the rotation center requires re-loading the SVG. Supporting the ability to set a skin's rotation center after it is created makes the requiredscratch-renderfix much harder to implement.Furthermore, since the functionality to set a
Drawable's rotation center is currently effectively unused, changing the parts ofscratch-renderthat involve rotation centers could break it unknowingly, causing future headaches if others try to use the API.Finally, as I mentioned earlier, rotation centers now belong to
Skins (which correspond to costumes), so it doesn't make sense to consider them a "Drawableproperty".There was one case in which updating a costume's rotation center actually did something: when first loading a bitmap, the costume rotation center was not divided by 2. The call to
updateDrawableSkinIdRotationCenterwhen setting a target's costume, which did properly set the rotation center for bitmap costumes, hid this oversight.