ci: automatically build release branch #8039
Open
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwillisf
requested review from
a team and
lostvirtue
and removed request for
a team
cwillisf
requested review from
colbygk and
AlexisGoodfellow
and removed request for
lostvirtue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
With CCI, running the "Create release branch and PRs" workflow would automatically cause a build & deploy cycle.
With GHA, actions taken by one workflow won't automatically trigger another workflow. Because of that, the "Create release branch and PRs" workflow creates the branch and PRs but does not build and deploy the new branch as it did before. Earlier today, I waited for the "Create release branch" workflow to finish, and then I manually dispatched the CI/CD workflow to deploy the release branch for our testing session.
This change adds an explicit workflow call to make that happen automatically. This is similar to the logic in the "Daily TX Pull" workflow in
scratch-l10n, for example.Test Coverage:
A full test won't be possible until the next time we create a release branch, but pushing this change and making a PR is a partial test.